Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rfb rust keywords 6723 v2 #1986

Closed
wants to merge 2 commits into from
Closed

Rfb rust keywords 6723 v2 #1986

wants to merge 2 commits into from
+61 −0

Conversation

catenacyber
Copy link
Collaborator

Ticket

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6723

#1985 with separate test to have min-version: 8

@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Jul 19, 2024
This was referenced Jul 19, 2024
Closed
Closed
jufajardini
jufajardini reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding a test for the integer keyword usage.

The only thing to note is whether we'll have a separate ticket for these to-rust changes for RFB or not (in case we may need to update any ticket references here).

This was referenced Jul 26, 2024
Closed
Closed
@victorjulien victorjulien mentioned this pull request Aug 7, 2024
Merged
@victorjulien
Copy link
Member

Merged in #2003, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini jufajardini left review comments

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catenacyber @victorjulien @jufajardini